I get nothing. So after a while I told my bosses I would simply stop doing it, since the work to compensate us was still “in progress”. It helped the rest of the team get a free day per on call week, which I guess is something, but still not enough for me personally.
I told them I wasn’t even sure it was legal in my country (Spain) which I guess they didn’t even discuss with legal, or legal didn’t even blink.
On the contrary, I think that the left piece of code is not building constrains prematurely and actually enables you to modularize it away when needed.
Sure, if the logic grows, if it needs to scale, if the team increases in size… then it makes sense to modularize it. But building something from the very beginning to achieve that is going to impose constraints that make it harder to reason about and harder to refactor; you’ll have to break down the previous structures and boundaries built by the function heavy example, which will probably introduce needless indirections.