Yeah git reset --soft then the sha of the last commit you want included in reset.

This is helpful. Thanks. Didnt even realize it. No need to use something to point out how its not a good look. It’s still good to bring more awareness around how sites like Github are becoming a more of walled gardens. I agree with everything else you said though.

Express, JavaScript (with JSDocs+TS for type-checking) and Postgres

Looks like a decent setup. Vanilla JS is the way to go for the best performance. Avoids vendor lock-in and those skills never go out of date. 👍

And also try to make tests that don’t have to change if you refactor in future (although there are some exceptions)

Renovate is great. Plus there’s just something about Github owning dependabot that always bothered me.

The issue with node is the single threading and having to scale with worker threads AFAIK

People always say this but its not technically correct and can be misleading.

Technically, JavaScript runs single threaded but not Node.js itself and certainly not when using it on the backend in something like Express. IO operations and other things tooling libraries do can cause you to run out of a thread pool. But Node.js, when handling requests, gives you much of the benefit of multithreading without having to deal with multithreaded code.

Yeah, JavaScript/TS doesn’t get a great rep being used on the backend. But I use it on quite a few of my projects, one of which gets thousands of requests per minute. I was skeptical of whether or not using Node on the backend would hold up, but the performance has been stellar… pretty surprising, actually.

This was always a no-brainer imo. Love what node has been doing so far 👏

I like RoR but “Ruby on Rails” and “modern” in the same sentence seems kind of funny.

But then again, “modern” is subjective in itself and most of the websites I see these days (even built and maintained by large companies) seem pretty ancient.

No semantic HTML, still using divs everywhere, no accessibility, all these useless third-party dependencies and lockins vs the new APIs being introduced natively in the browser every day, ajax, jquery instead of using the web platform, hell-- most web developers don’t even know what a dialog element is.

20+ year programmer and I’ve never made an account on SO. During the early stages of SO, the idea of making people have to earn a certain amount of SO karma just to ask a question seemed like an odd obstacle to place in front of new users. I get why they may want to do it but decisions like that are already divisive and toxic to being with.

I blame the rise of frameworks, libraries, and IDEs.

My thoughts exactly. Frameworks on top of frameworks with a lot of cruft that will incrementally make software slower and buggy.

That, coupled with the fact that business owners just want things shipped. Quality aside, I dont even think they care about products being good anymore 🥲

I was thinking about switching to GitLab. But after reading your comment… not so much.

Yeah works amazingly well on Linux too

Hmm cloud-based solutions for this scare me. But ok if open source.

It may be difficult if the context behind those decisions are lost, but I imagine it can be doable for a smaller company, assuming the amount is reasonable. And ofc, there’s always a chance the extra overhead may piss off a few engineers 😆

The meetings approach is interesting. I think we did those for RFCs but I remember they were very very long and unproductive. I think the company size matters when determining the right approach.

we generally first discuss the topic and then write the accepted decision in an ADR. So, there isn’t much room for discussion/voting afterwards.

This makes sense. I guess it would cut down on the noise in the PR since, at the point of its creation, it’s already been accepted. Our repos have so many other teams contributing to them that it’s hard to rally everyone to build consensus on an ADR beforehand. I guess we could hold meetings, but having feedback in a PR allows us to go back and look at what discussions led to a decision later on.

How does your team build consensus before opening the PR? Is it through slack or some other chat tool? Or maybe a meeting?

We just thumbs up the PR for an ADR if we’re in favor of it. Does that differ from the ADR format?

We use them at my company. I love how new engineers can’t just come into our codebase and start doing huge refactors. ADRs kind of force them to explain their rationale. We also use them to upvote on whether an architectural change should be implemented or not.