jameseb@lemm.eetoRust@programming.dev•Getting into rust and could use some pointersEnglish
6·
1 year agoA few things I noticed:
- In
http::request::parse()
, do you actually need aBufReader
? It would be better to make it generic over something implementingBufRead
, that allows what you have but also makes tests and examples easier since you wouldn’t have to open a TCP connection just to do something that is essentially string parsing. - In
http::response::Response::to_string()
, that match on lines 78-85 makes me uneasy, because you are silently changing the status code if it isn’t one you recognise. It would be better to signal an error. It would be even better to just check when the status code is set (perhaps with a status code enum to list the ones you support, since what you have isn’t all the defined codes) so that you can’t fail when converting to a string. - Consider whether you need a special
to_string()
method at all, or whether you can just implementDisplay
(which gives youto_string()
for free via theToString
trait). - You are using
String
as an error type pretty much everywhere. The better approach is to create an enum representing all the possible errors, so that a user of your library can match against them. Make the enum implementError
andDisplay
and it will fit fine into the rest of the error handling infrastructure. There are crates likethiserror
that can reduce the boilerplate around this. - You have an
io.rs
that doesn’t appear to be connected to anything. - You have a
main.rs
, which seems off in something that sounds like it should be purely a library crate. You probably want that to be an example or an integration test instead.
That’s all I could see with a quick look. In terms of general advice: remember to look at warnings, run cargo clippy
, and look at the API guidelines.
I’m glad my points we’re helpful!
There is some documentation on examples in the Cargo book. The basic procedure is to put it in an
examples
directory alongside thesrc
directory (and in its own subfolder if it has multiple files), and you can add an entry for it in theCargo.toml
(although it should automatically detect it if you put it in theexamples
directory, so that is only strictly necessary if you want to change the default settings).