• 0 Posts
  • 14 Comments
Joined 1 year ago
cake
Cake day: August 24th, 2023

help-circle

  • No one cares if you leave a ticket open due to a bug or incomplete feature

    Product sure as hell cares if you’re going to ship a bug or incomplete feature.

    Never worked at company that wasn’t the case in over 15 years.

    Product owns the work they ask us to do. We do their bidding.

    And we certainly aren’t allowed to just change the scope of tickets at our own discretion without checking in





  • This is my typical experience as well, too many people don’t do a code review of their own PR first.

    When I was a junior, I had this coworker who did all my reviews. I was doing my absolute best and wanted to show that I was learning, so I would review all my work before submitting it and think, how would he review and respond to this code.

    That just stuck with me and it’s my normal practice now.

    I eventually learned that’s not as normal as I thought. I also tend to give better code reviews than others.

    Edit: the other thing I do is check in with who will be reviewing my code well before I submit anything someone might think is weird and have a discussion about it before the reveiw. If it’s weird, there might be a better way unless were stuck due to technical debt or something, and doing that early vs at the end usually saves time.